Summary by CodeRabbit

• Bug Fixes
  • Improved accuracy of group membership counts to reflect only users currently active in Discord, providing more reliable member tallies across groups.

Walkthrough

Refactored enrichGroupDataWithMembershipInfo to compute group member counts by first batching user document queries and filtering for users marked as in_discord, then counting only those mappings instead of all mappings. This ensures member counts reflect active Discord members rather than all historical user-mapping records.

Changes

Sequence Diagram(s)

sequenceDiagram
    participant fn as enrichGroupDataWithMembershipInfo
    participant db as User DB
    participant filter as in_discord Filter
    participant count as Count Aggregation

    fn->>db: Batch fetch user docs for all roleIds
    db-->>fn: Return user documents
    fn->>filter: Filter users where in_discord = true
    filter-->>fn: Filtered user set
    fn->>count: Count mappings for each roleId
    count-->>fn: roleIdToCountMap (filtered)
    fn-->>fn: Return groups with accurate memberCounts

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

• Areas requiring attention:
  • Batch user fetch implementation and performance implications with large user counts
  • Filtering logic correctness—verify in_discord field is reliably set and reflects actual Discord membership status
  • Mapping between original groupsToUserMappings and filtered batch results to ensure no mappings are incorrectly skipped
  • Test coverage adequacy—ensure test data setup properly reflects Discord presence/absence scenarios

Possibly related issues

• Update implementation of filter users service to fetch only filtered users from firestore #1023: Directly related; both address inflated group member counts by filtering mappings to include only users marked in_discord.

Poem

🐰 Hop along, dear Discord band,
No more phantom counts in the land!
We count only those here to stay,
Active members brightening the day.
Accurate now, our membership rings true—
A rabbit's delight in numbers renewed! 🥕

Pre-merge checks and finishing touches

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

I was unable to write a description for this pull request. This could be because I only found files I can't scan.